Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I wanted to submit this start on the jasmine task integration. #9 is related.
I thought it would be better for us to have something we can play with right away, even if there's still some work to do. The grunt-jasmine-task plugin is pretty good. It was really easy to integrate (apart from
grunt.loadNpmTasks
we cant' use, I've added some comments to exlain incli/tasks/h5bp.js
we might remove later on).The only caveat is that it only works on OSX right now, windows and linux are getting timeout error that are apparently not easy to find & fix (issue 4 in original repo)
We'll probably also need to add a specrunner and the jasmine environment in the init task, as well as the according grunt config, something like (borrowed from the plugin doc)
I'll see if I can find something about this issue with other system than osx. I managed to reproduced the error on a CentOS box, with the default spec runner that comes with Jasmine 1.2.0.