Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter data: wrong index is passed to [MFLCoreDataIntrospection entityDescription:index] #6

Closed
delebedev opened this issue Mar 8, 2013 · 4 comments

Comments

@delebedev
Copy link
Contributor

  1. Select the very first entity
  2. dataSource returns selected index = 1 and passes it to [self.objModel entities][1]

Expected Result:
The index passed to [MFLCoreDataIntrospection entityDescription:index] should be 0 in this case.

@yepher
Copy link
Owner

yepher commented Mar 8, 2013

I believe I fixed that in this commit but I will double check:

Commit: cad77ba [cad77ba]
Parents: d211c6a
Author: Chris Wilson chris@mfluent.com
Date: March 8, 2013 3:16:39 PM CST
Labels: HEAD origin/master origin/develop origin/HEAD master develop

Fixes an exception when right clicking on "ENTITY' in the entity table.

@delebedev
Copy link
Contributor Author

I believe it's not enough: check my pull request: #7

@delebedev
Copy link
Contributor Author

Btw, a noob question: I see my merge commits in the pull request, is that ok?

@yepher
Copy link
Owner

yepher commented Mar 8, 2013

@garnett with regards to your "....merge commits in the pull request...". If I understand your question properly. You should "rebase" when you pull the changes. This will make the graph look better.

@yepher yepher closed this as completed in 83c9c19 Mar 8, 2013
aubb pushed a commit to aubb/CoreDataUtility that referenced this issue Jan 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants