-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test snapshots #323
Test snapshots #323
Conversation
Really cool stuff! I wonder if we could add a hint to |
I wondered exactly this too! But my searches didn't yield anything useful. Are you aware if it's actually possible? Edit: I tried again and found out how to do it. |
Hmm weirdly Github doesn't seem to be using it in the diffs. Maybe it needs to be committed first, or a caching issue? Anyway, not a massive deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
It's done on a low priority background job so might take a bit to update: |
bbbbb52
to
f30c214
Compare
@brendanzab any idea why the output would be different on different Rust versions? The
vs.
|
Ohhhh this seems like it might be testing the merge commit using #322? Where I now have a list of parsed expressions per position (we might have to revisit this approach to rendering these). So we might need to regenerate the snapshot. Not sure why it is different per rust version though - that is very strange 😵💫 |
24a8e36
to
734f886
Compare
734f886
to
46280c2
Compare
Righto finally got a passing build |
Yay :) |
This is an initial pass at adding and verifying test output via snapshots.
snap
files currently capture expectedstdout
andstderr
for each test. A rudimentary diff is shown when a mismatch occurs. To update snapshots/create missing snap shots run the test withFATHOM_UPDATE_SNAP
set (any value will do).It's likely that there are further extensions/improvements that can be done to this. I figured these can be driven by the experience of using this initial version.