Allow different formats at the same ref position #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
commented
Mar 29, 2022
| let parsed_refs = refs.entry(pos).or_insert(Vec::with_capacity(1)); | ||
|
|
||
| if (parsed_refs.iter()) | ||
| .find(|r| self.conversion_context().is_equal(&r.format, &format)) |
There was a problem hiding this comment.
It would be nice to make this more efficient. This would be easier if we could somehow assign a unique id to formats at compile time. Either that or have separate position stores for each format we plan to parse (this is is a bit like how Kaitai compiles format parsers, IIUC). This is complicated due to:
- runtime data dependencies in format descriptions
- the fact that formats can be constructed at runtime (I think Remove Type-in-Type #316 might resolve this)
There was a problem hiding this comment.
Now I'm curious if Kaitai allows instances to be parametrised by values 🤔
There was a problem hiding this comment.
Seems like no, Kaitai does not allow instances to have parameters, as far as I can see. Nor can they handle mutual recursion of the font tables (they seem to skip the tables where this comes up, like htmx?).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple linked formats to occupy the same position in the binary file.
Currently this just renders the different formats as a list corresponding to each position in the CLI. In the future I'd want to explore a different way of displaying these - perhaps something like
pos : Repr format = ...orpos : format = ...(if we add format -> repr coercions) - but this would require glued evaluation of top-level items to avoid swamping users with massive format descriptions.