Lifecycle method componentWillReceiveProps is deprecated

[nbkhope]

Will there be any updates to the package so that it no longer uses the deprecated lifecycle method componentWillReceiveProps?

Ref https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops

connectModal, for example, uses it:

redux-modal/src/connectModal.ts

Line 39 in 3bacc12

componentWillReceiveProps(nextProps: ConnectModalProps) {

[veeramarni]

@yesmeck Do you need PR to replace componentWillReceiveProps with componentDidUpdate?

[yesmeck]

@veeramarni Yes

[codeskills-nl]

Just run: npx react-codemod rename-unsafe-lifecycles (or rename manually componentWillReceiveProps to UNSAFE_ componentWillReceiveProps)
It will suppress the warning

[codeskills-nl]

Replace componentWillReceiveProps with:

  componentDidUpdate() {
    const { modal } = this.props;

    if (isUndefined(modal.show)) {
      return this.unmount();
    }

    if (!modal.show) {
      return destroyOnHide ? this.props.destroy(name) : this.hide();
    }

    if (!resolve) {
      this.show();
    }

    if (resolve) {
      const resolveResult = resolve({ props: modal.props });
      if (!isPromise(resolveResult)) {
        return this.show();
      }
      resolveResult.then(() => {
        this.show();
      });
    }
  }

[masaokiba]

@yesmeck are you fixing this deprecation issue?

[MonteLogic]

I am interested in this issue as well.

[yesmeck]

PRs are welcome

…

On Sun, Oct 20, 2019 at 14:10 dchavours ***@***.***> wrote: I am interested in this issue as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#95?email_source=notifications&email_token=AADRRZKOTZTK5YSQAKLVJJLQPPY65A5CNFSM4GT7Z5LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYDGXI#issuecomment-544224093>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADRRZKBYNLFPNHMKWPHG5LQPPY65ANCNFSM4GT7Z5LA> .

[leo-esaki]

@yesmeck I wanna create a PR but I don't have a permission?

[yesmeck]

@leo-esaki You need to fork this repo before creating a PR.

[yesmeck]

Released 4.0.0