Remove extraneous map toPersistValue call. (#1468)

The list produced by `toPersistFields entity` is already of type `[PersistValue]`.
yesodweb · Feb 1, 2023 · 356a081 · 356a081
1 parent 6fdbf84
commit 356a081
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/persistent/ChangeLog.md b/persistent/ChangeLog.md
@@ -1,5 +1,11 @@
 # Changelog for persistent
 
+## unreleased
+
+* [#1460] https://github.com/yesodweb/persistent/pull/1468
+    * Remove extraneous `map toPersistValue` call in the `mkInsertValues`
+      function, as it evaluates to `id`.
+
 ## 2.14.4.4
 
 * [#1460] https://github.com/yesodweb/persistent/pull/1460

diff --git a/persistent/Database/Persist/Sql/Util.hs b/persistent/Database/Persist/Sql/Util.hs
@@ -243,7 +243,6 @@ mkInsertValues
 mkInsertValues entity =
     Maybe.catMaybes
         . zipWith redactGeneratedCol (getEntityFields . entityDef $ Just entity)
-        . map toPersistValue
         $ toPersistFields entity
   where
     redactGeneratedCol fd pv = case fieldGenerated fd of