Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous map toPersistValue call. #1468

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Jan 23, 2023

The list produced by toPersistFields entity is already of type [PersistValue]. This can be checked by putting a type hole inside, which will reveal that toPersistValue call in this context has PersistValue -> PersistValue type and boils down to id.

Before submitting your PR, check that you've:

  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@arrowd
Copy link
Contributor Author

arrowd commented Jan 31, 2023

Bump. This is a trivial one-line PR.

@parsonsmatt
Copy link
Collaborator

Good catch, thank you! Please add a changelog entry, under a new unreleased section (since it isn't a bugfix or feature, just a refactor)

The list produced by `toPersistFields entity` is already of type `[PersistValue]`.
@parsonsmatt parsonsmatt merged commit 356a081 into yesodweb:master Feb 1, 2023
@arrowd arrowd deleted the extra-topersistvalue branch February 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants