Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runMigrationSilently doesn’t work #640

Closed
Profpatsch opened this issue Dec 9, 2016 · 3 comments
Closed

runMigrationSilently doesn’t work #640

Profpatsch opened this issue Dec 9, 2016 · 3 comments

Comments

@Profpatsch
Copy link

Profpatsch commented Dec 9, 2016

On my linux machine runMigrationSilently just returns an empty lists and still prints everything to <wherever I log it>.

The code uses capture_ from silently, which tries to capture a handle output, writes it to a temp file and reads that file back again. That’s quite a brittle hack! And probably completely unnecessary …

@gregwebs
Copy link
Member

I presume you mean runMigrationSilent. I don't know how it could return an empty list if there was a migration to apply.

Do you want this function to be deprecated?

@Profpatsch
Copy link
Author

I think it’s a good function to have, but it should not try to capture from the output handle, rather use internal data structures and return them instead of printing.

merijn added a commit to merijn/persistent that referenced this issue Oct 11, 2019
parsonsmatt pushed a commit that referenced this issue Oct 11, 2019
… broken runMigrationSilent (#971)

* Add safer *Quiet variations of runMigrationSilent

This commit fixes/provides workarounds for: #474, #640, #948, and #966.

* Fix stupid typos in initial patch

* Update ChangeLog with PR number
@parsonsmatt
Copy link
Collaborator

Fixed by #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants