-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runMigrationSilently doesn’t work #640
Comments
I presume you mean Do you want this function to be deprecated? |
I think it’s a good function to have, but it should not try to capture from the output handle, rather use internal data structures and return them instead of printing. |
merijn
added a commit
to merijn/persistent
that referenced
this issue
Oct 11, 2019
This commit fixes/provides workarounds for: yesodweb#474, yesodweb#640, yesodweb#948, and yesodweb#966.
Fixed by #971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On my linux machine
runMigrationSilently
just returns an empty lists and still prints everything to<wherever I log it>
.The code uses
capture_
fromsilently
, which tries to capture a handle output, writes it to a temp file and reads that file back again. That’s quite a brittle hack! And probably completely unnecessary …The text was updated successfully, but these errors were encountered: