-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runMigrationSilent
is not threadsafe
#966
Comments
merijn
added a commit
to merijn/persistent
that referenced
this issue
Oct 11, 2019
This commit fixes/provides workarounds for: yesodweb#474, yesodweb#640, yesodweb#948, and yesodweb#966.
Fixed by #971 |
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example errors:
This is because of the call to
hSilence [stderr]
which is not threadsafe.This call was added in response to #105 because of the way the postgres backend works.
I'm using
sqlite
, and with that call removed in #965, everything "Just works":tm: but that doesn't solve the problem for postgres.#105 mentions that you can silence postgres by setting
PGOPTIONS
to--client-min-messages=warning
.So a few options:
runMigrationSilent
non-threadsafe. Then I'll userunMigration
and just get a bunch of nonsense output:runMigrationSilent
into a version that useshSilence
and one that doesn't.hSilence
and instruct postgres users to setPGOPTIONS
accordingly.I'm in favour of the second, with some good docs.
I could do that as part of #965
The text was updated successfully, but these errors were encountered: