Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming values in persistent-template #1203

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Renaming values in persistent-template #1203

merged 2 commits into from
Mar 22, 2021

Conversation

danbroooks
Copy link
Contributor

@danbroooks danbroooks commented Mar 15, 2021 •
edited
Loading

Refactors some variable names in TH.hs as a contribution towards #1156

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@danbroooks danbroooks changed the title Rename entDef and fieldDef values Renaming values persistent-template Mar 15, 2021
@danbroooks danbroooks changed the title Renaming values persistent-template Renaming values persistent-template Mar 15, 2021
@danbroooks danbroooks changed the title Renaming values persistent-template Renaming values in persistent-template Mar 15, 2021
parsonsmatt
parsonsmatt approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Thank you! This is awesome.

@parsonsmatt parsonsmatt changed the base branch from master to matt/pre-template-removal March 22, 2021 22:31
@parsonsmatt parsonsmatt merged commit f975100 into yesodweb:matt/pre-template-removal Mar 22, 2021
@parsonsmatt parsonsmatt mentioned this pull request Mar 22, 2021
Merged
parsonsmatt added a commit that referenced this pull request Mar 22, 2021
@parsonsmatt @danbroooks
Matt/pre template removal (#1217)
48e83a2 
* Renaming values in persistent-template (#1203)

* Rename entDef and fieldDef values

* Update changelog

* tidy up changelog

Co-authored-by: Dan Brooks <danbroooks@users.noreply.github.com>
@danbroooks danbroooks deleted the th-rename-variables branch April 22, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGabriel MaxGabriel MaxGabriel approved these changes

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbroooks @MaxGabriel @parsonsmatt