Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show keyFromValues error #1268

Merged
merged 3 commits into from
May 11, 2021
Merged

Show keyFromValues error #1268

merged 3 commits into from
May 11, 2021

Conversation

3kyro
Copy link
Contributor

@3kyro 3kyro commented May 10, 2021

Backends send helpful information on composite key errors but we don't get to see it.

-Before submitting your PR, check that you've:

  • [x ] Ran stylish-haskell on any changed files.
  • [ x] Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • [ x] Update the Changelog.md file with a link to your PR
  • [ x] Bumped the version number if there isn't an (unreleased) on the Changelog
  • [ x] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is a good improvement 😄

There's two suggestions to review.

Please update the persistent/persistent.cabal file with the new version number, and I'll get this released shortly.

The CI failure appears to be spurious - if you merge master, it should be fixed and run fine.

Thanks!

persistent/ChangeLog.md Show resolved Hide resolved
persistent/Database/Persist/Sql/Util.hs Outdated Show resolved Hide resolved
persistent/Database/Persist/Sql/Util.hs Outdated Show resolved Hide resolved
@3kyro
Copy link
Contributor Author

3kyro commented May 11, 2021

I've added your review changes, thanks :)

@parsonsmatt parsonsmatt merged commit 7e85a7c into yesodweb:master May 11, 2021
@parsonsmatt
Copy link
Collaborator

awesome, thanks!

@parsonsmatt
Copy link
Collaborator

Released as persistent-2.13.0.1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants