Fix duplicate entity checks #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Jun 17, 2021
persistent/Database/Persist/TH.hs
Outdated
| newEnts = | ||
| Set.toList $ | ||
| Set.fromList allEnts | ||
| Set.\\ Set.fromList (map unbindEntityDef preexistingEntities) |
There was a problem hiding this comment.
Lol, sigh, alas, oh well, so silly,,,
|
mm no this is broken still looks like the code in the |
parsonsmatt
commented
Jun 18, 2021
There was a problem hiding this comment.
OK, I've got it fixed. Mostly by skipping the transformation from ModelNameId to Key ModelName if we're not in the mpsGeneric mode.
Another bug from #1204 :\
| @@ -28,7 +28,7 @@ import Database.Persist.TH.SharedPrimaryKeySpec (User, UserId) | |||
|
|
|||
| mkPersistWith sqlSettings $(discoverEntities) [persistLowerCase| | |||
|
|
|||
| Profile | |||
| ProfileX | |||
There was a problem hiding this comment.
persistent now fails to generate code for Profile because Profile is already a table defined in discoverEntities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the ChangelogCloses #1288