[persistent-mysql] Rename SomeField type to HandleUpdateCollision #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, so the pattern synonym stuff is breaking with earlier GHCs (no type signatures on 7.8, can't export related pattern synonym on 7.10). I can write CPP to fix that, but that'll require some multiline string literals to be rewritten. |
|
I don't think it's required that we have a breaking API change on persistent-mysql, but the name |
|
Merged to the newer-conduit branch, part of PR #773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to get this in before 3.0 馃槃
SomeFieldworked as a name before the responsibility of the type grew. Renaming it makes it more clear what it does and what it is for. Hiding the constructors allows us to add additional combinators without them being breaking changes -- I want to addcopyUnlessIn,modifyUsingand possibly others at some point.I'm not 100% on the new type alias and pattern constructor for
SomeField. They'll prevent it from breaking with a compile error and instead issue a deprecation notice for migration, which is helpful, but also extends the amount of backwards compatibility cruft we have to carry around.