You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of conduit (1.3) is going to be released soon, and will be switching from monad-control over to unliftio-core. This PR moves the persistent API over as well for compatibility, while still keeping compatibility with the older version (though Travis may discover a few things I still need to tweak to make this work). It also drops usage of deprecated operators and type synonyms in conduit 1.3, and cleans up a few other warnings.
Is there any objection to me merging this and making a new major release of persistent, persistent-sqlite, persistent-postgresql, persistent-mysql, and persistent-mongoDB when I'm releasing the new version of conduit?
Alright, I've merged both #760 and #734 into this branch, and I've reverted #759. Can you mind giving those last commits a review to ensure I hit what you were looking for? Also, CC @parsonsmatt.
I think something was going wrong with the Travis build on this (Travis's UI said it had been running for over 6 hours without any progress) so I killed it. Edit: I restarted it
I'm trying to use this latest commit for testing/updating persistent-typed-db and it's failing to build. Probably need to add conduit-1.3.0 into the stack.yaml?
I've been testing with a megarepo that includes all the deps, since I've been modifying all of the repos in lock step. The new conduit version isn't yet on Hackage. I've pushed a commit that adds appropriate extra-deps to hopefully get this compiling.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of conduit (1.3) is going to be released soon, and will be switching from
monad-controlover tounliftio-core. This PR moves the persistent API over as well for compatibility, while still keeping compatibility with the older version (though Travis may discover a few things I still need to tweak to make this work). It also drops usage of deprecated operators and type synonyms in conduit 1.3, and cleans up a few other warnings.Is there any objection to me merging this and making a new major release of persistent, persistent-sqlite, persistent-postgresql, persistent-mysql, and persistent-mongoDB when I'm releasing the new version of conduit?