New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax HTTP2 headers check. #621

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
3 participants
@lucasdicioccio
Contributor

lucasdicioccio commented May 24, 2017

HTTP/2-draft17 (e.g., used in gRPC) does not mandate an :authority pseudo header.
In fact, this pseudo header MUST be omitted in some HTTP/1.1 translation
cases.

More details at https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-8.1.2.3 .

Relax HTTP2 headers check.
HTTP/2-draft17 (e.g., used in gRPC) does not mandate an `:authority` pseudo header.
In fact, this pseudo header MUST be omitted in some HTTP/1.1 translation
cases.

More details at https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-8.1.2.3 .
@lucasdicioccio

This comment has been minimized.

Contributor

lucasdicioccio commented May 25, 2017

Note that the only Travis failing build was failing with:
The job exceeded the maximum time limit for jobs, and has been terminated.

@psibi

This comment has been minimized.

Member

psibi commented May 25, 2017

I have restarted that build.

@kazu-yamamoto kazu-yamamoto self-requested a review May 26, 2017

@kazu-yamamoto

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 3a1c271 into yesodweb:master May 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazu-yamamoto

This comment has been minimized.

Contributor

kazu-yamamoto commented May 26, 2017

Merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment