Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wai-extra: Catch the "file not found" exception in tempFileBackEndOpt… #706

Merged
merged 1 commit into from
Aug 14, 2018
Merged

wai-extra: Catch the "file not found" exception in tempFileBackEndOpt… #706

merged 1 commit into from
Aug 14, 2018

Conversation

dgaw
Copy link
Contributor

@dgaw dgaw commented Aug 14, 2018

A fix for #705

snoyberg
snoyberg requested changes Aug 14, 2018
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a minor version bump in the cabal file and a note in the ChangeLog?

@dgaw dgaw force-pushed the bugfix/tmp-cleanup-exception-catch branch from 8f89ac4 to 0f99969 Compare August 14, 2018 14:41
@dgaw
Copy link
Contributor Author

dgaw commented Aug 14, 2018

Thanks for the quick review. I've bumped the minor version and added a change log entry.

@snoyberg snoyberg merged commit f901afb into yesodweb:master Aug 14, 2018
@snoyberg
Copy link
Member

Thanks!

@snoyberg snoyberg mentioned this pull request Aug 14, 2018
Closed
@dgaw dgaw deleted the bugfix/tmp-cleanup-exception-catch branch August 14, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgaw @snoyberg