Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network.Wai.Test: Add support for source locations to assertion primitives #812

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

sol
Copy link
Contributor

@sol sol commented Sep 17, 2020

In addition, this will result in more readable test failures.

Before:

before

After:

after


Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks!

@snoyberg snoyberg merged commit b53a99f into yesodweb:master Sep 17, 2020
@sol sol deleted the add-source-locations branch September 17, 2020 09:25
@sol
Copy link
Contributor Author

sol commented Sep 17, 2020

Thanks @snoyberg 👍

@snoyberg
Copy link
Member

The WaiTestFailure change broke some other packages, I'm going to undo that and rerelease.

@sol
Copy link
Contributor Author

sol commented Sep 17, 2020

@snoyberg bummer! It should have been a major version bump! My mistake, sorry for that!

I think dcd4e9f will not give us source locations. So reverting 357ef40 altogether would still be better than keeping parts of it.

Any chance that we can do this change with a major version bump?

@snoyberg
Copy link
Member

I'm not interested in a major version bump for this. It should be possible to get source locations without one.

See also #813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants