Using InvalidRequest instead of HTTP2Error #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazu-yamamoto
changed the title
|
Thanks. I will merge this in the next week. |
413 and 431 is in the semantics level while HTTP2Error is in the transport level. It is mis-use that response status is contained in ConnectionError.
kazu-yamamoto
force-pushed
the
proper-http2
branch
from
27b1194
to
6039b78
Compare
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm preparing http2 lib v4 since RFC9113 was published. http2 v4 discovered a flaw of #741.
413 and 431 is in the semantics level while HTTP2Error is in the transport level. It is mis-use that a response status code is contained in ConnectionError.
My review of #741 was not good enough. I'm very sorry.
I would like to add RequestHeaderFieldsTooLarge and PayloadTooLarge to InvalidRequest and use them instead of ConnectionError. This reduces the dependency from wai-extra to http2.
This PR also contains preparation for http2 v4.
Cc: @michalrus and @vlatkoB