Enable MySQL strict mode from the scaffolding #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -- (If you enable it in your my.cnf file, you can delete this code). | ||
| let appDatabaseConf = fromYamlAppDatabaseConf { myConnInfo = (myConnInfo fromYamlAppDatabaseConf) { | ||
| MySQL.connectOptions = | ||
| ( MySQL.connectOptions (myConnInfo fromYamlAppDatabaseConf)) ++ [MySQL.InitCommand "SET SESSION sql_mode = 'STRICT_ALL_TABLES';\0"] |
There was a problem hiding this comment.
The ByteString here is explicitly null-terminated to work around this issue (related PR: paul-rouse/mysql#17).
|
looks good to me |
MaxGabriel
added a commit
that referenced
this pull request
Aug 24, 2015
Enable MySQL strict mode from the scaffolding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would enable MySQL's strict mode for connections coming from the application. This causes MySQL to raise errors instead of silently truncating too-long data, among other changes. This PR would have prevented yesodweb/persistent#122.
Current wiki page about this: https://github.com/yesodweb/persistent/wiki/Database-Configuration#strict-mode