-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header type equality comparison #1418
Comments
Header keys are wrapped in the |
@snoyberg I think this |
I think it would be better to just wrap it in |
At the moment the code in #1417 would still need to be changed to use Eq on Header - does this actually go any wider than that code, or would it be best just to use CI for case-insensitivity there, for that one comparison? |
I would vote for using |
@psibi Up until now, there has been no comparison performed there that I'm aware of. 20/20 hindsight, it would make sense to use |
The equality comparison is case insensitive according to the HTTP specs. Right now, we don't make that distinction.
The text was updated successfully, but these errors were encountered: