Better monads #1464
Merged
Better monads #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also removes deprecation from `timeField` * Also mildly discourages using `timeFieldTypeText`
|
Should the docs (“While this is simply a @WriterT@”) be updated too? |
|
Hah, I didn't expect anyone to be reviewing this. Good catch. I'm not quite sure which (if any) of these experiments will end up making it onto master, so feedback on whether this is worth it at all is certainly welcome :). I'm currently experimenting with a pretty crazy subsite rewrite based on all of this, but it's not ready to be pushed, and I probably won't finish it until at least next week due to travel. |
…to better-monads
|
While you are doing some breaking changes, I think this is a good time to fix this also: #1418 (comment) |
In the implementation of contentTypeTypes make use of simpleContentType.
…into better-monads
3 tasks
This is much more consistent than suddenly using a ReaderT for subsites. Thanks to @jprider63 for the inspiration for this, I think it cleans things up a lot!
Update `mkYesodWith` and refactor so that `mkYesod` uses the context parser
Technically unnecessary since it's inherited from conduit, but this is more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.