Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tag helpers #1659

Closed
jezen opened this issue Feb 6, 2020 · 1 comment · Fixed by #1663
Closed

Add meta tag helpers #1659

jezen opened this issue Feb 6, 2020 · 1 comment · Fixed by #1663

Comments

@jezen
Copy link
Member

jezen commented Feb 6, 2020

In a few of my projects I maintain a module called Util.Meta which just contains a bunch of functions like these. Is there any reason not to bundle these functions with Yesod? If adding these seems reasonable, I'm happy to send a PR.

@snoyberg
Copy link
Member

snoyberg commented Feb 6, 2020

Seems fine to me, go for it 💪

jezen added a commit that referenced this issue Mar 30, 2020
It's common that a website author will want to add a specific
description and Open Graph image to a given page in their website. These
functions are simple conveniences to add these meta tags to the document
head.

I decided against simply adding all possible meta tags, because not all
of them are useful, and even in the case of Open Graph tags, many of
them should be set only once and they should use the same value for the
entire website. In those cases, it's probably better for the website
author to add those tags in their layout template.

Closes #1659
jezen added a commit that referenced this issue Mar 30, 2020
It's common that a website author will want to add a specific
description and Open Graph image to a given page in their website. These
functions are simple conveniences to add these meta tags to the document
head.

I decided against simply adding all possible meta tags, because not all
of them are useful, and even in the case of Open Graph tags, many of
them should be set only once and they should use the same value for the
entire website. In those cases, it's probably better for the website
author to add those tags in their layout template.

Closes #1659
jezen added a commit that referenced this issue Mar 30, 2020
* Add functions for setting description and OG meta

It's common that a website author will want to add a specific
description and Open Graph image to a given page in their website. These
functions are simple conveniences to add these meta tags to the document
head.

I decided against simply adding all possible meta tags, because not all
of them are useful, and even in the case of Open Graph tags, many of
them should be set only once and they should use the same value for the
entire website. In those cases, it's probably better for the website
author to add those tags in their layout template.

Closes #1659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants