-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta tag helpers #1659
Labels
Comments
Seems fine to me, go for it 💪 |
jezen
added a commit
that referenced
this issue
Mar 30, 2020
It's common that a website author will want to add a specific description and Open Graph image to a given page in their website. These functions are simple conveniences to add these meta tags to the document head. I decided against simply adding all possible meta tags, because not all of them are useful, and even in the case of Open Graph tags, many of them should be set only once and they should use the same value for the entire website. In those cases, it's probably better for the website author to add those tags in their layout template. Closes #1659
5 tasks
jezen
added a commit
that referenced
this issue
Mar 30, 2020
It's common that a website author will want to add a specific description and Open Graph image to a given page in their website. These functions are simple conveniences to add these meta tags to the document head. I decided against simply adding all possible meta tags, because not all of them are useful, and even in the case of Open Graph tags, many of them should be set only once and they should use the same value for the entire website. In those cases, it's probably better for the website author to add those tags in their layout template. Closes #1659
jezen
added a commit
that referenced
this issue
Mar 30, 2020
* Add functions for setting description and OG meta It's common that a website author will want to add a specific description and Open Graph image to a given page in their website. These functions are simple conveniences to add these meta tags to the document head. I decided against simply adding all possible meta tags, because not all of them are useful, and even in the case of Open Graph tags, many of them should be set only once and they should use the same value for the entire website. In those cases, it's probably better for the website author to add those tags in their layout template. Closes #1659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a few of my projects I maintain a module called
Util.Meta
which just contains a bunch of functions like these. Is there any reason not to bundle these functions with Yesod? If adding these seems reasonable, I'm happy to send a PR.The text was updated successfully, but these errors were encountered: