Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for setting description and OG meta #1663

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

jezen
Copy link
Member

@jezen jezen commented Mar 30, 2020

It's common that a website author will want to add a specific
description and Open Graph image to a given page in their website. These
functions are simple conveniences to add these meta tags to the document
head.

I decided against simply adding all possible meta tags, because not all
of them are useful, and even in the case of Open Graph tags, many of
them should be set only once and they should use the same value for the
entire website. In those cases, it's probably better for the website
author to add those tags in their layout template.

Closes #1659

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@jezen jezen requested a review from snoyberg March 30, 2020 05:09
It's common that a website author will want to add a specific
description and Open Graph image to a given page in their website. These
functions are simple conveniences to add these meta tags to the document
head.

I decided against simply adding all possible meta tags, because not all
of them are useful, and even in the case of Open Graph tags, many of
them should be set only once and they should use the same value for the
entire website. In those cases, it's probably better for the website
author to add those tags in their layout template.

Closes #1659
@jezen jezen force-pushed the add-description-and-og-meta-tags branch from a3c2061 to 645092e Compare March 30, 2020 05:10
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI discovered a compilation error, but once that's fixed this should be good to go.

yesod-core/ChangeLog.md Show resolved Hide resolved
@jezen
Copy link
Member Author

jezen commented Mar 30, 2020

@snoyberg Am I ok to squash and merge this?

@snoyberg
Copy link
Member

Yes 👍

@jezen jezen merged commit 59f601a into master Mar 30, 2020
@jezen jezen deleted the add-description-and-og-meta-tags branch March 30, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add meta tag helpers
2 participants