Add functions to yesod-test to support the new CSRF middleware #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGabriel
force-pushed
the
csrfMiddlewareYesodTest
branch
from
b4c12f8
to
d2b992f
Compare
| @@ -93,6 +95,7 @@ module Yesod.Test | |||
| -- * Grab information | |||
| , getTestYesod | |||
| , getResponse | |||
| , getRequestCookies | |||
There was a problem hiding this comment.
I don't know the best spot for this function, either in the export list or in the source code.
|
Uploaded |
MaxGabriel
force-pushed
the
csrfMiddlewareYesodTest
branch
from
d2b992f
to
374195b
Compare
|
Thanks for handling this issue from every angle :) Testing is often forgotten about |
gregwebs
added a commit
that referenced
this pull request
Aug 21, 2015
Add functions to yesod-test to support the new CSRF middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to add CSRF tokens from cookies, supporting the new CSRF middleware added in #1017.