Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to yesod-test to support the new CSRF middleware #1058

Merged
merged 1 commit into from Aug 21, 2015

Conversation

@MaxGabriel
Copy link
Member

commented Aug 20, 2015

This PR adds functions to add CSRF tokens from cookies, supporting the new CSRF middleware added in #1017.

@MaxGabriel MaxGabriel force-pushed the MaxGabriel:csrfMiddlewareYesodTest branch from b4c12f8 to d2b992f Aug 20, 2015

@MaxGabriel

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2015

@snoyberg or @gregwebs Can you upload yesod-core-1.4.14 to Hackage so that yesod-test can depend on it?

@@ -93,6 +95,7 @@ module Yesod.Test
-- * Grab information
, getTestYesod
, getResponse
, getRequestCookies

This comment has been minimized.

Copy link
@MaxGabriel

MaxGabriel Aug 20, 2015

Author Member

I don't know the best spot for this function, either in the export list or in the source code.

This comment has been minimized.

Copy link
@gregwebs

gregwebs Aug 21, 2015

Member

looks fine to me

@snoyberg

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

Uploaded

@MaxGabriel MaxGabriel force-pushed the MaxGabriel:csrfMiddlewareYesodTest branch from d2b992f to 374195b Aug 20, 2015

@gregwebs

This comment has been minimized.

Copy link
Member

commented Aug 21, 2015

Thanks for handling this issue from every angle :) Testing is often forgotten about

gregwebs added a commit that referenced this pull request Aug 21, 2015
Merge pull request #1058 from MaxGabriel/csrfMiddlewareYesodTest
Add functions to yesod-test to support the new CSRF middleware

@gregwebs gregwebs merged commit 6d15e7c into yesodweb:master Aug 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@snoyberg snoyberg removed the in progress label Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.