Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exports some internals and fix version bounds #1318

Merged
merged 4 commits into from
Dec 7, 2016
Merged

Exports some internals and fix version bounds #1318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1697a3
export toWaiAppYre
s9gf4ult Dec 2, 2016
2bd3a93
fix blaze-markup version bounds
s9gf4ult Dec 2, 2016
47ef360
export `getGetMaxExpires`
s9gf4ult Dec 5, 2016
80f0b3c
Add comments and bump minor version to 1.4.29
s9gf4ult Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions yesod-core/Yesod/Core/Dispatch.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@ module Yesod.Core.Dispatch
, mkYesodSubData
, mkYesodDispatch
, mkYesodSubDispatch
-- *** Helpers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to add new exports, they need to have Haddocks and @since comments. Can you add those, and do a minor version bump in the .cabal file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoyberg fixed

, getGetMaxExpires
-- ** Path pieces
, PathPiece (..)
, PathMultiPiece (..)
, Texts
-- * Convert to WAI
, toWaiApp
, toWaiAppPlain
, toWaiAppYre
, warp
, warpDebug
, warpEnv
Expand Down
2 changes: 1 addition & 1 deletion yesod-core/yesod-core.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ library
, resourcet >= 0.4.9 && < 1.2
, lifted-base >= 0.1.2
, blaze-html >= 0.5
, blaze-markup >= 0.5.1
, blaze-markup >= 0.7.1
, data-default
, safe
, warp >= 3.0.2
Expand Down