Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports some internals and fix version bounds #1318

Merged
merged 4 commits into from Dec 7, 2016

Conversation

Projects
None yet
3 participants
@s9gf4ult
Copy link
Contributor

s9gf4ult commented Dec 6, 2016

Would be great to have this on Hackage.

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Dec 6, 2016

What's the reason for the lower version bound bump?

@@ -17,13 +17,16 @@ module Yesod.Core.Dispatch
, mkYesodSubData
, mkYesodDispatch
, mkYesodSubDispatch
-- *** Helpers

This comment has been minimized.

Copy link
@snoyberg

snoyberg Dec 6, 2016

Member

If we're going to add new exports, they need to have Haddocks and @since comments. Can you add those, and do a minor version bump in the .cabal file?

This comment has been minimized.

Copy link
@s9gf4ult

s9gf4ult Dec 7, 2016

Author Contributor

Ok.

This comment has been minimized.

Copy link
@s9gf4ult

s9gf4ult Dec 7, 2016

Author Contributor

@snoyberg fixed

@s9gf4ult

This comment has been minimized.

Copy link
Contributor Author

s9gf4ult commented Dec 7, 2016

What's the reason for the lower version bound bump?

compilation error:

./yesod/yesod-core/Yesod/Core/Widget.hs:112:27-32:
    Could not deduce (H.ToMarkup TB.Builder)
      arising from a use of ‘toHtml’
    from the context (MonadWidget m, HandlerSite m ~ site)
      bound by the type signature for
                 toWidget :: (MonadWidget m, HandlerSite m ~ site) =>
                             TB.Builder -> m ()
      at Yesod/Core/Widget.hs:112:5-12
    In the second argument of ‘(.)’, namely ‘toHtml’
    In the expression: toWidget . toHtml
    In an equation for ‘toWidget’: toWidget = toWidget . toHtml

http://hackage.haskell.org/package/blaze-markup-0.7.1.1/changelog

- 0.7.1.0 
* Relax `QuickCheck` dependency to allow 2.9 
* Add text builder instances

yesod-core does not build without text builder instances, which is added since blaze-markup-0.7.1.

@psibi

This comment has been minimized.

Copy link
Member

psibi commented Dec 7, 2016

I remember seeing such an error in Travis in my PR yesterday: https://travis-ci.org/yesodweb/yesod/jobs/181651004#L438

@snoyberg snoyberg merged commit f54b924 into yesodweb:master Dec 7, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Dec 7, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.