-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exports some internals and fix version bounds #1318
Conversation
What's the reason for the lower version bound bump? |
@@ -17,13 +17,16 @@ module Yesod.Core.Dispatch | |||
, mkYesodSubData | |||
, mkYesodDispatch | |||
, mkYesodSubDispatch | |||
-- *** Helpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to add new exports, they need to have Haddocks and @since
comments. Can you add those, and do a minor version bump in the .cabal file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snoyberg fixed
compilation error:
http://hackage.haskell.org/package/blaze-markup-0.7.1.1/changelog
|
I remember seeing such an error in Travis in my PR yesterday: https://travis-ci.org/yesodweb/yesod/jobs/181651004#L438 |
Thanks! |
Would be great to have this on Hackage.