Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultErrorHandler handles text/plain request. #1520

Merged
merged 1 commit into from Jun 13, 2018

Conversation

Projects
None yet
3 participants
@StevenXL
Copy link
Member

StevenXL commented Jun 8, 2018

Fix Issue #622

@StevenXL

This comment has been minimized.

Copy link
Member Author

StevenXL commented Jun 8, 2018

@snoyberg Not sure what to make of this. The Travis CI passed but AppVeyor failed. If changes are needed, please let me know.

@StevenXL StevenXL force-pushed the StevenXL:text-plain-error branch 2 times, most recently from 8d926cf to c263ee2 Jun 8, 2018

@ncaq

This comment has been minimized.

Copy link
Contributor

ncaq commented Jun 9, 2018

I think repository should split for package…
CI is heavy.

@ncaq

This comment has been minimized.

Copy link
Contributor

ncaq commented Jun 9, 2018

Now I remember, appveyor is stop of something, reason is not heavy.

@StevenXL

This comment has been minimized.

Copy link
Member Author

StevenXL commented Jun 10, 2018

@ncaq sorry - should I be changing something in the code? Is it not ready to be merged in?

@ncaq

This comment has been minimized.

Copy link
Contributor

ncaq commented Jun 11, 2018

I think this trouble reason is not this change.
Because master is break.
yesod 1.0.2 - AppVeyor
I am a contributor, I am not committer. so I do not know if it can merge.

@snoyberg snoyberg referenced this pull request Jun 12, 2018

Closed

Broken Windows build #1523

@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 12, 2018

We can ignore the AppVeyor failure here, let's discuss in #1523.

@snoyberg
Copy link
Member

snoyberg left a comment

Can you add a minor version bump to the cabal file and add a note to the ChangeLog about the change?

@StevenXL StevenXL force-pushed the StevenXL:text-plain-error branch from c263ee2 to a63bf16 Jun 13, 2018

@StevenXL

This comment has been minimized.

Copy link
Member Author

StevenXL commented Jun 13, 2018

@snoyberg Version bump added to changelog and cabal file.

@snoyberg snoyberg merged commit cae2a91 into yesodweb:master Jun 13, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@snoyberg

This comment has been minimized.

Copy link
Member

snoyberg commented Jun 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.