Add default text/plain error formatting #1306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Nov 24, 2016
| <h1>Not logged in | ||
| <p style="display:none;">Set the authRoute and the user will be redirected there. | ||
| |] | ||
| defaultErrorHandler resp = case resp of |
There was a problem hiding this comment.
Would it be possible to switch back to the original function pattern matching in place of the case statement, and just move the where clause definitions to top level functions? It would make it much easier to see in the history what the actual change here was.
There was a problem hiding this comment.
Sure, I thought it was possible this would be a problem.
|
Bump |
|
Good call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622
I refactored
defaultErrorHandlerto be a case statement so I could put the helper functions in awhereblock. If that's bad style or unnecessary change I can get rid of it. Also, I couldn't find any tests for error messages returning the correctcontent-type, so I'd rather ask about that here than try to write my own and end up reinventing the wheel (obviously if there really are no tests for that, I'll be happy to write them).