Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Improper 406 Responses #1540
I wanted to present this PR as a discussion on fixing the issue with the
There is a lot to clean up in the code. For example, if we keep
However, is the general solution to the problem adequate? The original problem that the tests surface is that we have an error handler (
If this gets a thumbs up I can clean up this code and, hopefully, get all the other tests to pass.
P.S. I forgot to mention that this only fixes the
@snoyberg Please take a look at the current solution.
It seems to me that the problem is that
It seems to me that this behavior was added in this commit.
The reason I felt comfortable changing that work is:
Tagging @gregwebs to get his thoughts on this as well.
Happy to take directions on this from the team, but this seemed like a correct, clean change.
I'm OK with heading in this direction. It seems like perhaps we should have a separate function like
But a change like this certainly needs to be called out clearly in the ChangeLog.