Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functions generating Open Graph metadata #1709

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix functions generating Open Graph metadata #1709

merged 3 commits into from
Nov 19, 2020

Conversation

eahlberg
Copy link
Contributor

@eahlberg eahlberg commented Nov 18, 2020 •
edited
Loading

Fixes #1708

  • Bumped the version number

- [ ] Documented new APIs with Haddock markup
- [ ] Added @since declarations to the Haddocks for new, public APIs

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

snoyberg
snoyberg approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 3b306b3 into yesodweb:master Nov 19, 2020
@eahlberg
Copy link
Contributor Author

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions generating Open Graph markup use the wrong attribute
2 participants
@eahlberg @snoyberg