Functions generating Open Graph markup use the wrong attribute

[eahlberg]

The functions setOGType and setOGImage use the name attribute (i.e. <meta name="og:type" >) but according to the Open Graph docs, the property attribute should be used, (i.e. <meta property="og:type" >).

If you agree with this change, I'll gladly add a PR.

[snoyberg]

PR would be great, thank you!

…

On Wed, 18 Nov 2020 at 5:30 PM Eric Ahlberg ***@***.***> wrote: The functions setOGType <https://hackage.haskell.org/package/yesod-core-1.6.18.6/docs/Yesod-Core-Widget.html#v:setOGType> and setOGImage <https://hackage.haskell.org/package/yesod-core-1.6.18.6/docs/Yesod-Core-Widget.html#v:setOGImage> use the name attribute (i.e. <meta name="og:type" >) but according to the Open Graph docs <https://opengraphprotocol.org/#types>, the property attribute should be used, (i.e. <meta property="og:type" >). If you agree with this change, I'll gladly add a PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1708>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMCB7H2UIAYEFO23FHFJTSQPSAXANCNFSM4T2D2SAQ> .