yesod-persistent: don't depend on persistent-template if we don't have to #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to If our version of 'persistent' is sufficiently new, then we don't need a dependency on the empty 'persistent-template' package.
snoyberg
reviewed
Mar 31, 2023
| @@ -13,12 +13,13 @@ homepage: http://www.yesodweb.com/ | |||
| description: API docs and the README are available at <http://www.stackage.org/package/yesod-persistent> | |||
| extra-source-files: README.md ChangeLog.md | |||
|
|
|||
| flag persistent_has_persistent_template | |||
| default: True | |||
There was a problem hiding this comment.
IIRC, this should have manual: False, right?
There was a problem hiding this comment.
Interesting ... the automatic flag selection doesn't seem to work in stack. At least that is how I interpret the CI failures. Does stack have a different default for manual than cabal-install does?
There was a problem hiding this comment.
Stack doesn't do dependency solving, and therefore it would need to be told to override any defaults set in the cabal file.
|
"manual" is false by default according to https://cabal.readthedocs.io/en/stable/cabal-package.html#pkg-field-flag-manual. We could add it anyways, just to be explicit, I guess, but technically it should make no difference.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our version of
persistentis sufficiently new, then we don't need a dependency on the emptypersistent-templatepackage.