Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attoparsec-aeson to support aeson-2.2 #1818

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

Vekhir
Copy link
Contributor

@Vekhir Vekhir commented Sep 11, 2023

The module Data.Aeson.Parser is moved into attoparsec-aeson for aeson >=2.2. For aeson <2.2, attoparsec-aeson is an empty package, since the module exists within aeson.

This is the fix as suggested in #1802, but that PR was never updated for that.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

The module `Data.Aeson.Parser` is moved into attoparsec-aeson for aeson >=2.2.
For aeson <2.2, attoparsec-aeson is an empty package, since the module exists within aeson.
@parsonsmatt
Copy link
Contributor

Looks like we need to add aeson-attoparsec to Stackage before CI is going to pass.

@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 12, 2023

@parsonsmatt Isn't it already? https://www.stackage.org/package/attoparsec-aeson (with version 2.1.0.0). It probably wouldn't hurt to update it though

Additionally, the error messages states, confusingly, that the latest matching version is 2.2.0.0.

@snoyberg
Copy link
Member

Looks like the new package needs to be added to extra-deps in the stack.yaml file.

@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 13, 2023

Added attoparsec-aeson 2.1.0.0 to stack.yaml and updated the stack.yaml.lock file

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 11b7089 into yesodweb:master Sep 14, 2023
8 of 14 checks passed
@Vekhir Vekhir mentioned this pull request Sep 14, 2023
3 tasks
@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 14, 2023

Thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants