Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a IProxyListener instead of a IHttpListener, fixes #5 #8

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

fersingb
Copy link

@fersingb fersingb commented May 7, 2021

Hello,

Is there any good reason to use a IHttpListener instead of a IProxyListener? Don't we want to only modify messages coming from the browser anyway?

This is an attempt to fix #5 by implementing a IProxyListener instead of a IHttpListener.

An alternative would be to still use IHttpListener but use the toolFlag value to decide if we want to process the message or not. The "advantage" of using the IProxyListener is that it allows the users to see both the original and the edited request in the proxy tab.

@irsdl
Copy link

irsdl commented Apr 20, 2022

Can this be merged please and the plugin be added to BApp Store?

@B-i-t-K B-i-t-K merged commit fedc781 into yeswehack:master Apr 21, 2022
@B-i-t-K
Copy link
Member

B-i-t-K commented Apr 21, 2022

Thanks for PR!

I'll try to get the add-on into the Bapp Store.

@irsdl
Copy link

irsdl commented Apr 21, 2022

Thanks. I have now implemented the extension part in Sharpener extension v1.5 which will be released soon:
image

So you should be fine even if it cannot be added to BApp Store :)

@B-i-t-K
Copy link
Member

B-i-t-K commented Apr 21, 2022

So cool! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Length header is always updated
3 participants