Clean Up Reflection Warnings #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream warnings that will remain until we update pedestal and a few other bits: Reflection warning, io/pedestal/log.clj:686:26 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:688:16 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:692:20 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:695:20 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:735:17 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:737:17 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:740:19 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:742:19 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:772:21 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:774:21 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:798:19 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:800:26 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:801:36 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/log.clj:802:43 - reference to field span on io.opentracing.Scope can't be resolved.
Reflection warning, io/pedestal/http/route.clj:67:3 - call to static method decode on java.net.URLDecoder can't be resolved (argument types: unknown, java.lang.String).
Reflection warning, io/pedestal/http/route.clj:73:3 - call to static method encode on java.net.URLEncoder can't be resolved (argument types: unknown, java.lang.String).
Reflection warning, ring/util/codec.clj:95:5 - call to static method encode on java.net.URLEncoder can't be resolved (argument types: java.lang.String, unknown).
Reflection warning, ring/util/codec.clj:130:6 - call to static method decode on java.net.URLDecoder can't be resolved (argument types: java.lang.String, unknown).
Reflection warning, crypto/random.clj:28:12 - call to static method encodeHex on org.apache.commons.codec.binary.Hex can't be resolved (argument types: unknown).
Reflection warning, crypto/random.clj:28:3 - call to java.lang.String ctor can't be resolved.
Reflection warning, hiccup/util.clj:78:19 - call to static method encode on java.net.URLEncoder can't be resolved (argument types: java.lang.String, unknown).
Reflection warning, io/pedestal/http/jetty.clj:106:22 - call to org.eclipse.jetty.server.ServerConnector ctor can't be resolved.
Reflection warning, io/pedestal/http/jetty.clj:183:32 - call to org.eclipse.jetty.server.ServerConnector ctor can't be resolved.
Reflection warning, io/pedestal/http/jetty.clj:189:31 - call to org.eclipse.jetty.server.ServerConnector ctor can't be resolved. |
|
You still have a |
|
Yep, it's on a dev path so I leave it alone. |
kelvinqian00
approved these changes
Aug 24, 2021
As of the master merge 5 days ago, it's passing CI, am I missing something? There was actually a change merged in that improved the reliability of the conformance tests a good deal and this was an intermittent error, so I think it's good to go now. |
|
Since you mentioned that, I ran the conformance tests in lrsql and they work, so that's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on other PRs with @kelvinqian00 ,
lrsshould not make decisions like the setting of the global var*warn-on-reflection*for implementers. There are situations where reflection might be needed, and the option to suppress the warnings without the need for careful require order is a must.Remove all the direct sets for it and see if it can be put into user.clj or some similar.With deps + cli it is actually hard to do this in a way that works for everyone's repl. Adding it to the init namespaces of the in-memory dev LRS (and keeping it in bench) will have to do for now.