PERS-18 Add support for subregistrations #19
Conversation
| pat-fsm-map))))) | ||
| (get-in stmt ["context" "registration"] :no-registration) | ||
| ?sub-registration | ||
| (get-in stmt ["context" "extensions" subreg-iri "subregistration"])] |
There was a problem hiding this comment.
I think this may be incorrect
the subregistration extension is an array-valued context extension. The array MUST NOT be empty. Each value of the array MUST be an object with the properties in the table below.
| Name | Values |
|---|---|
| profile | The URI of a Profile present in the category context activities that this is a subregistration for. |
| subregistration | A variant 2 UUID as specified in RFC 4122. This is the subregistration identifier in the requirements above. |
There was a problem hiding this comment.
right now, this would result in (get [{"profile" "...", "subregistration" "..."} ...] "subregistration")
There was a problem hiding this comment.
Yeah I noticed that, so now the subregistration extension has to be an array/vector. The subregistration ID chosen is dependent on the "profile" key of the subregistration object.
There was a problem hiding this comment.
Taking a broader view, the Profile of the Pattern the Statement is being validated against must reference it in the category context activities:
MUST follow a Pattern from a Profile for every Statement that has the Profile in the category context activities.
so at some point that needs to be added (perhaps in this branch?)
There was a problem hiding this comment.
I think it makes sense to check for one or more profile reference category activities within all statements passed into pattern validation. If they don't have the profile reference, then statement batch is invalid
|
updates look good, see my response to your comments about expecting statements to contain 1 or more profile reference context activities |
|
Superseeded by #20 |
No description provided.