Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument and fix specs #34

Merged
merged 17 commits into from
Dec 20, 2021
Merged

Instrument and fix specs #34

merged 17 commits into from
Dec 20, 2021

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Dec 17, 2021

  • Update :vals field in template error map to always be a vector, even for Statement Ref errors (BREAKING)
  • Update fsm-spec/valid-transition-src-states? such that source states only have to be a subset, not equals to, the total states.
  • Add :meta? to spec for fsm/plus-nfa.
  • Correct instrumentation for read-next to work with NFAs as well as DFAs.
  • Let statement-ref/get-template-fn and statement-ref/get-statement-fn specs to allow for nil returns and fix arg generation.
  • Fix subregistration specs in utils/statement.
  • Add missing :every-val-present? entry to ::template/pred spec.
  • Fix validator-spec, create-template-validator and create-template-predicate template specs.
  • Fix typo in ::persephone/validator-fn and ::persephone/predicate-fn spec names.
  • Align specs for validate-statement-errors and validate-statement (for :fn-type :errors).
  • Add missing ::persephone/print? spec for match-statement.
  • Fix bug in ::persephone/error spec.

@kelvinqian00 kelvinqian00 merged commit e9dc089 into template_api_update Dec 20, 2021
@kelvinqian00 kelvinqian00 deleted the instrument branch December 20, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants