Merge pull request #82 from yetanalytics/LRS-82

LRS-82 Allow empty contextActivities map
yetanalytics · Jan 12, 2024 · 135ad19 · 135ad19
2 parents 00cd108 + f790daa
commit 135ad19
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/xapi_schema/spec.cljc b/src/xapi_schema/spec.cljc
@@ -944,10 +944,10 @@
 (s/def :context/contextActivities
   (conform-ns "contextActivities"
               (s/and
-               (s/keys :req [(or :contextActivities/parent
-                                 :contextActivities/grouping
-                                 :contextActivities/category
-                                 :contextActivities/other)])
+               (s/keys :opt [:contextActivities/parent
+                             :contextActivities/grouping
+                             :contextActivities/category
+                             :contextActivities/other])
                (restrict-keys :contextActivities/parent
                               :contextActivities/grouping
                               :contextActivities/category

diff --git a/test/xapi_schema/spec_test.cljc b/test/xapi_schema/spec_test.cljc
@@ -376,8 +376,8 @@
                      ["foo"])))
 
 (deftest context-activities-map-test
-  (testing "cannot be empty"
-    (should-not-satisfy ::xs/context-activities {})))
+  (testing "can be empty"
+    (should-satisfy :context/contextActivities {})))
 
 (deftest context-test
   (testing "can be empty"