updated to allow empty strings and empty objects #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 10, 2019 11:28
… spec to avoid breaking specs which depend upon the spec non-empty-string
… other empty things
FeLungs
requested review from
deathtenk and
milt
and removed request for
deathtenk
|
@deathtenk this patch should resolve the disconnect we have been discussing. This PR will need to be approved, merged, and then deployed to take effect |
|
I'd like to make sure the conformance tests pass on an LRS using this validator before moving forward on this, I could swear there used to be a test that failed if you didn't omit them. |
|
Sounds good |
|
accounted for within #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to account for #65