Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Misp Json format #990

Merged
merged 31 commits into from
Feb 2, 2024
Merged

Import Misp Json format #990

merged 31 commits into from
Feb 2, 2024

Conversation

sebdraven
Copy link
Collaborator

No description provided.

tomchop
tomchop requested changes Jan 25, 2024
View reviewed changes
core/common/misp_to_yeti.py Show resolved Hide resolved
core/common/misp_to_yeti.py Outdated Show resolved Hide resolved
tests/apiv2/import_data.py Outdated Show resolved Hide resolved
tests/apiv2/import_data.py Outdated Show resolved Hide resolved
udgover
udgover requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start but some questions to answer. We should also agree on the formatter / linter to use because lots of changes comes from formatting and review is harder.

Finally, you MUST add the authentication check for the new API endpoint.

core/common/misp_to_yeti.py Show resolved Hide resolved
core/common/misp_to_yeti.py Outdated Show resolved Hide resolved
core/schemas/observable.py Outdated Show resolved Hide resolved
core/web/apiv2/import_data.py Show resolved Hide resolved
core/web/webapp.py Outdated Show resolved Hide resolved
@sebdraven sebdraven merged commit 8416bd9 into main Feb 2, 2024
2 checks passed
@sebdraven sebdraven deleted the import_json_data branch February 2, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchop tomchop tomchop approved these changes

@udgover udgover Awaiting requested review from udgover

Assignees
No one assigned
Labels
tasks:feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebdraven @udgover @tomchop