Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make paths relative #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fkohlgrueber
Copy link

@fkohlgrueber fkohlgrueber commented May 15, 2020

This PR changes two paths from absolute to relative. This fixed 404s when serving the app from a route other than /. With these changes, the app can be deployed to github pages for example with wasn't working before (e.g. see this repo; rendered).

As far as I can see, this doesn't break any existing cases.

@jstarry
Copy link
Member

jstarry commented May 16, 2020

@fkohlgrueber thanks! I think it should stay as an absolute path, though. I don't think that serving from a path other than / is as common as SPA web apps that support different routes using something like yew-router. In that case, the path should be absolute since files are all served from the root url.

How about we add a note in the README explaining to devs that fall into your camp that they need to use a relative path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants