Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Component::change impl mandatory #1071

Merged
merged 1 commit into from Apr 4, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Apr 4, 2020

Problem

A common mistake that Yew devs make is properly handling the change lifecycle method. This is mostly because Yew does not require an implementation. Until #830 is implemented, implementing change should be required.

@jstarry
Copy link
Member Author

@jstarry jstarry commented Apr 4, 2020

Case in point, found a bug in one of the examples

@jstarry jstarry merged commit 8edf136 into yewstack:master Apr 4, 2020
1 check passed
@jstarry jstarry deleted the require-change branch Apr 4, 2020
@wathiede wathiede mentioned this pull request Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant