Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yew-macro] Improve error message #1219

Merged
merged 1 commit into from
May 13, 2020
Merged

[yew-macro] Improve error message #1219

merged 1 commit into from
May 13, 2020

Conversation

kaoet
Copy link
Contributor

@kaoet kaoet commented May 13, 2020

  • missing identifier after with as in <Button with>
  • missing property value as in <input autofocus />

Fixes #1179

* [X] missing property value as in `<input autofocus />`
* [X] missing identifier after `with` as in `<Button with>`
@jstarry
Copy link
Member

jstarry commented May 13, 2020

So much better, thanks!

@jstarry jstarry merged commit e417cea into yewstack:master May 13, 2020
@kaoet kaoet deleted the miss-value branch May 13, 2020 03:43
jstarry pushed a commit that referenced this pull request May 14, 2020
* [X] missing property value as in `<input autofocus />`
* [X] missing identifier after `with` as in `<Button with>`
mergify bot pushed a commit that referenced this pull request May 14, 2020
* [X] missing property value as in `<input autofocus />`
* [X] missing identifier after `with` as in `<Button with>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yew-macro] Improve error message when props do not have values
2 participants