Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartialEq for VChild #1242

Merged
merged 2 commits into from
May 17, 2020
Merged

Implement PartialEq for VChild #1242

merged 2 commits into from
May 17, 2020

Conversation

kellpossible
Copy link
Contributor

@kellpossible kellpossible commented May 17, 2020 •
edited by jstarry
Loading

Fixes #1216

Implement PartialEq trait for VChild just by comparing the Component::Properties when they themselves implement PartialEq.

jstarry
jstarry previously approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Before merging, can you run cargo fmt?

@mergify mergify bot dismissed jstarry’s stale review May 17, 2020 15:22

Pull request has been modified.

@jstarry jstarry merged commit 5b0ecc0 into yewstack:master May 17, 2020
@kellpossible kellpossible deleted the vchild-partialeq branch May 18, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarry jstarry jstarry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PartialEq for VChild
2 participants
@kellpossible @jstarry