Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for optional attributes on HTML elements/tags #1433

Closed
wants to merge 11 commits into from
Closed

Add support for optional attributes on HTML elements/tags #1433

wants to merge 11 commits into from

Commits on Jul 23, 2020

  1. Add support for optional attributes on HTML elements/tags 

    Closes yewstack#903
    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    666fbd7 View commit details
    Browse the repository at this point in the history

  2. Fix a couple of minor details

    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    60ef22b View commit details
    Browse the repository at this point in the history

  3. Follow quote_spanned! documentation

    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3f007f0 View commit details
    Browse the repository at this point in the history

  4. Remove undesirable example

    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    c99c69e View commit details
    Browse the repository at this point in the history

  5. Add documentation for optional attributes

    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e229f0e View commit details
    Browse the repository at this point in the history

  6. Move optional token handling from HtmlDashedName to HtmlProp

    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    36d5a9c View commit details
    Browse the repository at this point in the history

  7. Do various requested changes to implementation 

    * Use fully qualified types in macro output
* Use fully qualified method calls for better error messages
* Remove support for optional attributes on boolean attributes
    @ilyvion
    ilyvion committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    081c51a View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Merge branch 'master' into issue-903

    @ilyvion
    ilyvion committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    df2434c View commit details
    Browse the repository at this point in the history

  2. Add error message for using optional attribute on HtmlList 

    Also, move tests where they belong
    @ilyvion
    ilyvion committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    8139f58 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Simon <simon@siku2.io>
    @ilyvion @siku2
    ilyvion and siku2 committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    7bea4a1 View commit details
    Browse the repository at this point in the history

  2. Apply remaining suggestions from code review

    @ilyvion
    ilyvion committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    3f29688 View commit details
    Browse the repository at this point in the history