Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v0.18 file upload example #2054

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

mc1098
Copy link
Contributor

@mc1098 mc1098 commented Sep 14, 2021

Description

Note this is updating the v0.18 example because we still link to them in the documentation.

Fixes #2035

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@mc1098
Copy link
Contributor Author

mc1098 commented Sep 14, 2021

Yeah, I'm not surprised about the Clippy failure because of v0.18 code trips it 🙃
I have checked this change and have run the example - so if you are happy with the approach I think we can side step Clippy this time :)

@mc1098 mc1098 changed the title Fix file upload example Fix v0.18 file upload example Sep 14, 2021
@siku2 siku2 merged commit 77252d4 into yewstack:v0.18 Sep 14, 2021
@mc1098 mc1098 deleted the v0.18-fix-file-upload branch September 15, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants