Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate publish workflows into one #3026

Merged
merged 2 commits into from Dec 11, 2022

Conversation

hamza1311
Copy link
Member

Description

Consolidate publish-* workflows into one

This new workflow will be invoked in the same way, except it also takes a space separated list of packages to publish. This change will also guard against any issues that may come up because of running cargo release many times

Checklist

  • I have reviewed my own code
  • I have added tests

@hamza1311 hamza1311 added A-ci Area: The continuous integration meta Repository chores and tasks labels Dec 10, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 10, 2022
Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is currently no way to specify a multi-option input to a manually run workflow. A necessary evil of avoiding to code duplication is to remember the way to invoke this but cargo release would probably give good enough errors.

@hamza1311
Copy link
Member Author

Yes, it's the cargo error message if invalid name is passed. I thought of adding a step to validate the input but doing it in bash seemed unnecessarily complex, especially since cargo was going to take care of it anyway

@hamza1311
Copy link
Member Author

hamza1311 commented Dec 10, 2022

@siku2 seems like you have to merge it. It isn't letting me because of permission error: "workflow scope is required" (no idea what that means)

Screenshot_20221211-015244.png

Nevermind, it was GH app acting up

@hamza1311 hamza1311 merged commit 0ad939b into yewstack:master Dec 11, 2022
WorldSEnder pushed a commit to WorldSEnder/yew that referenced this pull request Mar 18, 2023
* Consolidate publish-* workflows into one

* Update workflow name
WorldSEnder pushed a commit to WorldSEnder/yew that referenced this pull request Mar 18, 2023
* Consolidate publish-* workflows into one

* Update workflow name
hamza1311 added a commit that referenced this pull request Mar 19, 2023
* Consolidate publish-* workflows into one

* Update workflow name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration meta Repository chores and tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants