Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer pop_first if it is available #3084

Merged
merged 1 commit into from Jan 8, 2023
Merged

Conversation

futursolo
Copy link
Member

Description

This pull request prefers BTreeMap::pop_first if it is available.

Checklist

  • I have reviewed my own code
  • I have added tests

@futursolo futursolo added the A-yew Area: The main yew crate label Jan 8, 2023
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Visit the preview URL for this PR (updated for commit 4ed90f4):

https://yew-rs-api--pr3084-pop-first-38r9ljhm.web.app

(expires Sun, 15 Jan 2023 13:45:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 356.335 426.496 375.120 24.759
Hello World 10 606.898 657.983 624.078 14.927
Function Router 10 2309.119 2454.885 2376.639 42.047
Concurrent Task 10 1008.266 1010.875 1009.584 0.868

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 321.969 352.228 337.511 9.754
Hello World 10 635.212 667.621 649.881 10.968
Function Router 10 2499.750 2716.299 2591.118 67.983
Concurrent Task 10 1009.240 1011.257 1010.260 0.699

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 107.143 106.552 -0.591 -0.551%
boids 171.186 170.591 -0.595 -0.347%
communication_child_to_parent 91.269 90.667 -0.602 -0.659%
communication_grandchild_with_grandparent 105.624 105.033 -0.591 -0.559%
communication_grandparent_to_grandchild 101.460 100.870 -0.590 -0.581%
communication_parent_to_child 88.356 87.764 -0.593 -0.671%
contexts 108.138 107.541 -0.597 -0.552%
counter 86.297 85.706 -0.591 -0.685%
counter_functional 86.607 86.015 -0.593 -0.684%
dyn_create_destroy_apps 89.143 88.542 -0.601 -0.674%
file_upload 100.763 100.171 -0.592 -0.587%
function_memory_game 165.268 164.677 -0.591 -0.357%
function_router 349.594 348.978 -0.616 -0.176%
function_todomvc 160.225 159.631 -0.594 -0.371%
futures 225.341 224.753 -0.588 -0.261%
game_of_life 107.034 106.445 -0.589 -0.550%
immutable 182.008 181.230 -0.777 -0.427%
inner_html 82.714 82.121 -0.593 -0.717%
js_callback 112.285 111.688 -0.597 -0.531%
keyed_list 196.722 196.129 -0.593 -0.301%
mount_point 85.866 85.265 -0.602 -0.701%
nested_list 113.860 113.271 -0.589 -0.517%
node_refs 93.779 93.188 -0.592 -0.631%
password_strength 1549.746 1549.155 -0.591 -0.038%
portals 97.060 96.471 -0.589 -0.607%
router 319.659 319.081 -0.578 -0.181%
simple_ssr 151.872 151.284 -0.588 -0.387%
ssr_router 394.044 393.448 -0.596 -0.151%
suspense 109.481 108.882 -0.600 -0.548%
timer 89.165 88.571 -0.594 -0.666%
todomvc 141.659 141.066 -0.593 -0.418%
two_apps 86.917 86.326 -0.591 -0.680%
web_worker_fib 152.472 151.878 -0.594 -0.389%
webgl 85.421 84.823 -0.598 -0.700%

✅ None of the examples has changed their size significantly.

@futursolo futursolo merged commit b55be12 into yewstack:master Jan 8, 2023
WorldSEnder pushed a commit to WorldSEnder/yew that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants