Fix js-benchmark action #3202
Merged
Fix js-benchmark action #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
voidpumpkin
added
the
github_actions
voidpumpkin
commented
Apr 1, 2023
| @@ -49,8 +49,6 @@ jobs: | |||
| cache-dependency-path: js-framework-benchmark/package-lock.json | |||
|
|
|||
| - uses: Swatinem/rust-cache@v2 | |||
| with: | |||
| working-directory: yew | |||
There was a problem hiding this comment.
"Swatinem/rust-cache@v2" was updated and no longer understands this variable. Just gives a warning.
siku2
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One reason for failing benchmarks seem to be related to the change krausest/js-framework-benchmark#1201 , though i haven't dove deep to figure out details.
But in the end we don't need typescript support when running benchmarks and the proposed solution I think will last us long.
Also fixed how result processing is called.
Checklist