Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional options to fetch #579

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Add additional options to fetch #579

merged 1 commit into from
Aug 13, 2019

Conversation

davidkna
Copy link
Contributor

In addition to credentials allow setting more options on a fetch request.
This PR adds support fo the following options:

  • cache
  • mode
  • redirect

jstarry
jstarry requested changes Aug 12, 2019
View reviewed changes
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding these! Just one fix needed

src/services/fetch.rs Outdated Show resolved Hide resolved
src/services/fetch.rs Show resolved Hide resolved
jstarry
jstarry approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@jstarry jstarry merged commit b9894dc into yewstack:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarry jstarry jstarry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidkna @jstarry